Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtered non-alphanumeric chars, excluding dot. #9

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Filtered non-alphanumeric chars, excluding dot. #9

merged 2 commits into from
Oct 27, 2017

Conversation

ymslavov
Copy link
Contributor

No description provided.

@bbashy
Copy link
Contributor

bbashy commented Oct 27, 2017

What happens to git-hub.com?

@ymslavov
Copy link
Contributor Author

Fair point, just read the extra comments in the issue. Will amend as per them.

@bbashy bbashy mentioned this pull request Oct 27, 2017
Closed
@ymslavov
Copy link
Contributor Author

Props to @brendt and @bbashy for the comments.

@freekmurze freekmurze merged commit 1041249 into spatie:master Oct 27, 2017
@freekmurze
Copy link
Member

Thanks!

@bbashy
Copy link
Contributor

bbashy commented Oct 27, 2017

Since the sanitizeInput method is before the if sections, it's not letting it get past it for ?

https://github.com/betapeak/dnsrecords.io/blob/ac1671fb6ae9f5571db4ff7972c5ba7f69d16b51/app/Http/Controllers/HomeController.php#L23

freekmurze added a commit that referenced this pull request Oct 27, 2017
@freekmurze
extra fix for #9
5e4349f
@freekmurze
Copy link
Member

Nice catch, fixed.

@manniL manniL mentioned this pull request Feb 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymslavov @bbashy @freekmurze