You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is true, the ::make function does not allow named parameters there. Some of the countries like Switzerland have set their constructor to public to enable something like new CountryName(region:'AB-CD') that will work then. I will make an adjustment PR to reflect it in the README.md thanks for hinting that.
The other option would be to shift each country to a public constructor to initiate each county like new CountryName(region) but this a big PR and @Nielsvanpach needs to decide that
arnebr
added a commit
to arnebr/holidays
that referenced
this issue
May 13, 2024
What happened?
Just like the README says, I tried doing this to get all holidays for Hesse, Germany:
But this failed, as the make method doesn't take in named params. Instead, this works:
How to reproduce the bug
Package Version
1.8
PHP Version
8.3.0
Which operating systems does with happen with?
macOS
Notes
No response
The text was updated successfully, but these errors were encountered: