Add Ukrainian holidays #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you look at the failing tests? Thanks! |
|
Hi @Nielsvanpach, Sure, should be good now. |
src/Countries/Ukraine.php
Outdated
| } | ||
|
|
||
|
|
||
| protected function orthodox_eastern($year): string |
There was a problem hiding this comment.
In Country.php we already have a orthodox calculation. Could you verify if that works?
There was a problem hiding this comment.
Perfect, yes this is working correctly!
src/Countries/Ukraine.php
Outdated
| /** @return array<string, CarbonImmutable> */ | ||
| protected function variableHolidays(int $year): array | ||
| { | ||
| $easter = CarbonImmutable::createFromTimestamp($this->orthodox_eastern($year)) |
There was a problem hiding this comment.
You can use $this->easter($year) instead
src/Countries/Ukraine.php
Outdated
|
|
||
| class Ukraine extends Country | ||
| { | ||
| protected function __construct( |
There was a problem hiding this comment.
If you don't need the constructor, you can remove it
|
PR looks good! 👍 I'll leave this one open until I've seen some approvals! |
|
Thanks for reviewing. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Spatie!
There is one extra function for calculating the correct Eastern date due to the Meeus Julian algorithm or Revised Julian calendar