Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Taiwan holidays #124

Merged
merged 5 commits into from
Jan 27, 2024

Conversation

takeshiyu
Copy link
Contributor

@takeshiyu takeshiyu commented Jan 19, 2024

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.

Changes

  1. Added a new Taiwan class in the Holidays directory.
  2. Implemented holiday calculations specific to Taiwan, including both fixed-date holidays and those that require lunar calendar calculations.
  3. Used the ext-intl extension and IntlDateFormatter for accurate lunar calendar calculations, ensuring that holidays based on the lunar calendar are correctly determined.

Additional Notes

  1. The ext-intl extension is required for this addition. It is referenced in the composer.json file.

References

  1. https://publicholidays.tw/2024-dates/

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 3b1c0bd into spatie:main Jan 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants