Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 🇽🇰Kosovo🇽🇰 Holidays #151

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

AvdylKrasniqi
Copy link
Contributor

TODO: Implement Islamic Holidays

@AvdylKrasniqi
Copy link
Contributor Author

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh
I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

@ddouble-d
Copy link
Contributor

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

there is one in this PR #51 that implements the islamic calendar

@AvdylKrasniqi
Copy link
Contributor Author

@Nielsvanpach @thecaliskan @alphaolomi @amralsaleeh @ddouble-d @shoxrux1996 @captainjaypee01 @kakajansh I saw you were involved from other PR about the Islamic Holidays, so I am tagging you here! Perhaps we should all come with a common method in the Country class, so every country can call the method.

there is one in this PR #51 that implements the islamic calendar

I think we should implement a common method for all countries that do have Islamic holidays. On the PR #51 the solution is specifically for Malaysia

@thecaliskan
Copy link
Contributor

Every year the celebration of ramadan and sacrifice holiday's dates are different in Turkey and even inside of the other Islamic countries that's why it's impossible to calculate because the countries are releasing the holiday dates six month ahead not years before.

@amralsaleeh
Copy link

Every year the celebration of ramadan and sacrifice holiday's dates are different in Turkey and even inside of the other Islamic countries that's why it's impossible to calculate because the countries are releasing the holiday dates six month ahead not years before.

I'm with you 💯

@amralsaleeh
Copy link

So, Is there anything new?

@freekmurze freekmurze merged commit b2750bb into spatie:main Jan 23, 2024
8 checks passed
@Nielsvanpach
Copy link
Member

In case you want to add multi language support: https://github.com/spatie/holidays/tree/main/lang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants