Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japan support #160

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

mkokio
Copy link
Contributor

@mkokio mkokio commented Jan 22, 2024

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Create a new class in the Countries directory. It should extend the Country class. Done.
  2. Add a test for the new country in the tests directory. Done.
  3. Run the tests so a snapshot gets created. Done.
  4. Verify the result in the newly created snapshot is correct. Done.

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 915f16a into spatie:main Jan 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants