Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wales, england, scotland and northern ireland #162

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

SimonBarrettACT
Copy link
Contributor

@SimonBarrettACT SimonBarrettACT commented Jan 22, 2024

This adds bank holidays for Wales, England, Scotland and Northern Ireland.

If a bank holiday is on a weekend, a ‘substitute’ weekday becomes a bank holiday, normally the following Monday.

https://www.gov.uk/bank-holidays

Country codes

Wales: gb-cym
England: gb-eng
Scotland: gb-sct
Northern Ireland: gb-nir

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have you verified all results in the snapshots? I would only keep the tests that are actually verified by someone.

@SimonBarrettACT
Copy link
Contributor Author

Yes I have.

@Nielsvanpach
Copy link
Member

Great, thanks for your work on this!

@Nielsvanpach Nielsvanpach merged commit b41b7d1 into spatie:main Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants