Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Bangla language support for Bangladeshi holidays #182

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

jfBiswajit
Copy link
Contributor

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Does it make sense to return Bangla by default instead of English?

@jfBiswajit
Copy link
Contributor Author

jfBiswajit commented Jan 28, 2024

Thanks! Please check the changes. It returns Bangla names in English instead of Bangla font.

@Nielsvanpach Nielsvanpach merged commit 17c7849 into spatie:main Jan 30, 2024
8 checks passed
@Nielsvanpach
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants