New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing README.md to update region parameter in country constructor to a working example #184

Merged

Nielsvanpach merged 1 commit into spatie:main from arnebr:main

Jan 27, 2024

Contributor

arnebr commented Jan 27, 2024

Before the README.md region settings has been mixed with two different countries.

$holidays = Holidays::for(Austria::make(region: 'de-bw'))->get();

Austria has called a German region. I´ve adjusted it to the German working example and uppercased the region parameter as it is in the German class.


          Update region parameter in country constructor to a working example

17505a1

Member

Nielsvanpach commented Jan 27, 2024

Thanks!

Nielsvanpach merged commit a3d0e1f into spatie:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet