Adding Full Mandatory Mexican holidays #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantes4ur
changed the title
src/Countries/Mexico.php
Outdated
| return 'mx'; | ||
| } | ||
|
|
||
| /** @return array<string, CarbonImmutable> */ |
There was a problem hiding this comment.
The comments right?
For that part, done
tonaflcastelan
approved these changes
Jan 18, 2024
jndrdlx99
approved these changes
Jan 19, 2024
|
Thanks! Could you solve the merge conflicts? |
Already fixed, some other branch was merged with optional days. |
|
Great, thank you! |
|
I made some adjustments, could you verify if the governmentChangeDate() change is correct? |
LGTM! |
ssmusoke
pushed a commit
to ssmusoke/holidays
that referenced
this pull request
Jan 20, 2024
* feat(Mexico.php): rebase main to put mandatory days * feat(Mexico.php): finished dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nation-wide holidays for Mexico from the official government publication:
https://www.gob.mx/profedet/es/articulos/sabes-cuales-son-los-dias-de-descanso-obligatorio-para-este-2024
Article 74 of the Federal Labor Law indicates the following mandatory rest days:
I. January 1st;
II. The first Monday of February in commemoration of February 5th;
III. The third Monday of March in commemoration of March 21st;
IV. May 1st;
V. September 16th;
VI. The third Monday of November in commemoration of November 20th;
VII. October 1st every six years, when it corresponds to the transmission of the Federal Executive Power;
VIII. December 25th, and
IX. The day determined by federal and local electoral laws, in the case of ordinary elections, to conduct the electoral day.
Aside from these, any additional days are considered optional.