-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bangladesh holidays #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left feedback for minor changes.
tests/.pest/snapshots/Countries/BangladeshTest/it_can_calculate_bangladesh_holidays.snap
Outdated
Show resolved
Hide resolved
tests/.pest/snapshots/Countries/BangladeshTest/it_can_calculate_bangladesh_holidays.snap
Outdated
Show resolved
Hide resolved
75eda51
to
0527cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey there! Noticed most of holiday names are in their mother tongue – how about a sprinkle of Bengali magic to celebrate diversity?
|
Dont think bangla would be a good choice here. Only fixed dates are added here. |
Got it! |
Thanks! |
Co-authored-by: Ariful Alam <ariful.dev@miaki.com.bd>
No description provided.