Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indian holidays #220

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Conversation

webmavensteam
Copy link
Contributor

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.

tests/Countries/IndiaTest.php Outdated Show resolved Hide resolved
src/Countries/India.php Outdated Show resolved Hide resolved
src/Countries/India.php Outdated Show resolved Hide resolved
@webmavensteam
Copy link
Contributor Author

@Nielsvanpach Our test cases failed because of the below test.

image (1)

We have added a fix to it.

Also, we have a PHPSTAN error for the below file.

image

Would you like for us to fix that file also?

@webmavensteam
Copy link
Contributor Author

@Nielsvanpach We have added fix for above phpstan issue.

@Nielsvanpach Nielsvanpach merged commit 6313a94 into spatie:main Jun 13, 2024
1 check passed
@Nielsvanpach
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants