Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Philippine national holidays #25

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

kndrckjvr
Copy link
Contributor

I have based the data I have gathered from several official documents of the Philippine Government

  • Holidays of the Philippines for 2024 link
  • Araw ng Kagitingan Legislation link
  • National Heroes Day link

@kndrckjvr kndrckjvr changed the title add philippine's regular holidays add Philippine national holidays Jan 17, 2024
Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you rebase this branch so the tests can run?

src/Countries/Philippines.php Outdated Show resolved Hide resolved
@kndrckjvr
Copy link
Contributor Author

rebased and squashed!

@kndrckjvr kndrckjvr force-pushed the add_philippine_holiday branch 3 times, most recently from 89a31e9 to 4e627da Compare January 18, 2024 15:51
@freekmurze freekmurze merged commit 15ae9e9 into spatie:main Jan 19, 2024
1 check passed
@freekmurze
Copy link
Member

Thanks!

@rdpascua rdpascua mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants