Add United States Holidays #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcdigital
force-pushed
the
add-us-holidays
branch
2 times, most recently
from
3a66b38
to
2759b62
Compare
|
@arcdigital I would maybe consider adding all of the "bank" holidays. Without all of the federal holidays where the banks are closed, we would be unable to use this (I work in the finance industry). Thanks for submitting! |
arcdigital
force-pushed
the
add-us-holidays
branch
from
2759b62
to
85d65b2
Compare
|
I've updated with all the bank holidays. The US is tricky but I think that makes the most sense. |
src/Countries/UnitedStates.php
Outdated
| { | ||
| return array_merge([ | ||
| 'New Year\'s Day' => '01-01', | ||
| 'Juneteenth National Independence Day' => '06-19', |
There was a problem hiding this comment.
Am I right this is a only recent official holiday? For historical correctness, could you not include this for the years it wasn't an official holiday?
|
Sure I can do that, yes it is a newer holiday. I'll add that logic in. |
|
Just rebased it. I'll add the logic for Juneteenth. |
arcdigital
force-pushed
the
add-us-holidays
branch
from
a8185e8
to
5659ee9
Compare
|
@Nielsvanpach should be good to go! rebased, added the logic for Juneteenth, and a second test. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added all US Bank holidays.