Bolivian holidays #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase your branch on our main branch? That way I can run the tests |
rats4final
force-pushed
the
bolivian-holidays
branch
from
08814c4
to
2693923
Compare
|
alright i think it's done :) |
rats4final
force-pushed
the
bolivian-holidays
branch
2 times, most recently
from
2da865c
to
6aa4153
Compare
rats4final
force-pushed
the
bolivian-holidays
branch
from
6aa4153
to
a340521
Compare
|
All fixed |
| /** @return array<string, CarbonImmutable> */ | ||
| protected function variableHolidays(int $year): array | ||
| { | ||
| $easter = $this->easter((string) $year); |
There was a problem hiding this comment.
Suggested change
| $easter = $this->easter((string) $year); | |
| $easter = $this->easter($year); |
|
Thanks! |
Crawford30
pushed a commit
to Crawford30/holidays
that referenced
this pull request
Jan 19, 2024
* feature: add bolivian holidays * test: add bolivia test * test snap * fixed typo and phpstan * calculate correct easter date * Fix styling --------- Co-authored-by: rats4final <rats4final@gmail.con> Co-authored-by: rats4final <rats4final@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Bolivian holidays; for now, they are only nationwide holidays. However, this could change if this package adds support for regional holidays as well.
Based on: reference
Also this could be further improved by adding "conditional holidays" because afaik in Bolivia if any holiday lands on a Sunday, the government will most likely declare the following day as a holiday as well, so that everyone has the day off, this practice can also occur regionally