-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Australian Holidays #43
Conversation
eb6f4cc
to
8b2b951
Compare
29b35f2
to
2234633
Compare
These are the national holidays, that all states observe.
c243974
to
b00b128
Compare
Thanks! I'll leave this open until this has some approvals by others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me without going into the absolute absurdity that is "replacement public holidays" (i e. those certain public holidays that fall on a weekend so some states give a "replacement" public holiday on the following Monday)
Thanks @samlev I did think about the replacement days but decided against implementing something at this stage. The context of how the package is being used is a big factor to whether replacement days are useful or not. |
The tests seem a little flaky, when running all the tests locally I get between 1 and 3 fails. Uganda, Estonia and North Macedonia. |
Thanks, PR looks good! I'll have a look at the failing tests. |
These are the national holidays down to the state level.