Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danish holidays #5

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Danish holidays #5

merged 6 commits into from
Jan 18, 2024

Conversation

RootAccessPlease
Copy link

Added the public holidays for Denmark.

@Nielsvanpach
Copy link
Member

You should run the tests, so a snapshot of the dates can be generated.

@RootAccessPlease
Copy link
Author

You should run the tests, so a snapshot of the dates can be generated.

You're right!

},
{
"name": "Juleaften",
"date": "2025-12-12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you verify all generated results? It seems like something is not right yet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! Should be correct now.

@steffen25
Copy link

@RootAccessPlease Nice PR!

Do you think it makes sense to add support for Great Prayer Day prior to 2024?
Maybe it is enough to mention that in the docs somehow.

@RootAccessPlease
Copy link
Author

@steffen25 Great point! I've taken that into account in the latest commit.

@Nielsvanpach
Copy link
Member

Could you rebase this branch on main? This way the tests should run on CI.

@Nielsvanpach Nielsvanpach merged commit 2ff8351 into spatie:main Jan 18, 2024
13 of 14 checks passed
@Nielsvanpach
Copy link
Member

Thanks!

@Tor2r
Copy link
Contributor

Tor2r commented Jan 18, 2024

While making the holidays for Norway, I started by copying the Danish ones. Found an error with Easter Monday / Anden Påskedag
Ref: https://publicholidays.dk/2024-dates/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants