-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danish holidays #5
Conversation
You should run the tests, so a snapshot of the dates can be generated. |
You're right! |
}, | ||
{ | ||
"name": "Juleaften", | ||
"date": "2025-12-12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you verify all generated results? It seems like something is not right yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! Should be correct now.
@RootAccessPlease Nice PR! Do you think it makes sense to add support for Great Prayer Day prior to 2024? |
@steffen25 Great point! I've taken that into account in the latest commit. |
Could you rebase this branch on main? This way the tests should run on CI. |
…hat Great Prayer Day is no longer a public holiday in 2024.
Thanks! |
While making the holidays for Norway, I started by copying the Danish ones. Found an error with Easter Monday / Anden Påskedag |
Added the public holidays for Denmark.