Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement holidays for Austria #6

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Implement holidays for Austria #6

merged 2 commits into from
Jan 17, 2024

Conversation

felixfrey
Copy link
Contributor

No description provided.

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 26f476a into spatie:main Jan 17, 2024
1 check passed
@marlonbasten
Copy link

I added state-specific holidays in Austria to my PR. Can you maybe check if those are correct as I am not Austrian? 😅 #37

@felixfrey
Copy link
Contributor Author

felixfrey commented Jan 18, 2024

I added state-specific holidays in Austria to my PR. Can you maybe check if those are correct as I am not Austrian? 😅 #37

@marlonbasten The thing with state-specify holidays in Austria ist that they are not real "holidays" - shops are open and employees have to work. State-specifiy holidays mostly only apply to universities, schools and sometimes to government agencies. It is complicated. (https://de.wikipedia.org/wiki/Feiertage_in_%C3%96sterreich). The question is what the definition of a holiday is for this package.

@Nielsvanpach
Copy link
Member

I made this package to calculate the official public holidays. If the state-specific holidays in Austria are not real holidays, and people still have to work, I wouldn't include them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants