Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dutch holidays #67

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Update Dutch holidays #67

merged 8 commits into from
Jan 23, 2024

Conversation

ndijkstra
Copy link
Contributor

No description provided.

@basst85
Copy link

basst85 commented Jan 18, 2024

Exactly. Also mentioned this on X/Twitter: https://x.com/basst85/status/1747644878698217818

@basst85
Copy link

basst85 commented Jan 18, 2024

But looks like this is a duplicate issue:
#64

@ndijkstra
Copy link
Contributor Author

But looks like this is a duplicate issue: #64

For Oudejaarsdag, yes. But for the other changes no

@ju5t
Copy link

ju5t commented Jan 18, 2024

I think it should be eerste & tweede instead of 1e and 2e.

@ndijkstra
Copy link
Contributor Author

I think it should be eerste & tweede instead of 1e and 2e.

I agree! Those prefixes are with capital letters, right?

@ju5t
Copy link

ju5t commented Jan 18, 2024

I agree! Those prefixes are with capital letters, right?

Either is fine, but capitals make most sense in this package I think. Users can make it lowercase when it's in a sentence.

Pasen (eerste en tweede paasdag): zondag 31 maart en maandag 1 april 2024
Pinksteren (eerste en tweede pinksterdag): zondag 19 en maandag 20 mei 2024
Kerstmis (eerste en tweede kerstdag): woensdag 25 en donderdag 26 december 2024

@Nielsvanpach
Copy link
Member

Thanks! Could you fix the merge conflicts?

@Nielsvanpach
Copy link
Member

Happy to merge once all tests are green

@Nielsvanpach Nielsvanpach merged commit dcb66ef into spatie:main Jan 23, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants