Enhanced holiday dates in Ghana #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another round of review. |
|
Kindly review |
|
PR comments resolved. |
Ikpeba4ll
changed the title
|
When will this be merged? |
|
This PR has been in approved state for so long. Hope you haven't forgotten about it |
Nielsvanpach
reviewed
Feb 8, 2024
| @@ -5,7 +5,7 @@ | |||
| }, | |||
| { | |||
| "name": "Constitution Day", | |||
| "date": "2024-01-07" | |||
| "date": "2024-01-08" | |||
There was a problem hiding this comment.
Yes, the holiday is on 7th which is sunday so we observed it on 8th,
| @@ -5,7 +5,7 @@ | |||
| }, | |||
| { | |||
| "name": "Constitution Day", | |||
| "date": "2024-01-07" | |||
| "date": "2024-01-08" | |||
There was a problem hiding this comment.
Yes, the holiday is on 7th which is sunday so we observed it on 8th,
| @@ -5,7 +5,7 @@ | |||
| }, | |||
| { | |||
| "name": "Constitution Day", | |||
| "date": "2024-01-07" | |||
| "date": "2024-01-08" | |||
There was a problem hiding this comment.
Yes, the holiday is on 7th which is sunday so we observed it on 8th,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the holiday dates for Ghana.
Holidays are not observed on weekends so any holiday which falls on a weekend is pushed to the next monday
NB: *** There are no fixed dates for the Eid-Ul-Fitr and Eid-Ul-Adha because they are movable feasts.
The dates for their observation are provided by the Office of the Chief Imam in the course of the year.