-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Portuguese Holidays #9
Conversation
"date": "2024-01-01" | ||
}, | ||
{ | ||
"name": "Carnaval", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an official public holiday? It's not on the list here: https://publicholidays.pt/2024-dates/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s a tricky one, actually. It is not an official mandatory holiday (hence not appearing on the list) but it is a facultative holiday so it appears on most work contracts and the government validates it every year as a holiday for civil servants. In practical terms it is a holiday since nobody works and everything is closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately like you said it’s not oficial, many companies ignore it.
It should be omitted from this list, in my opinion.
Good job with the PR 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I'll remove it then.
Thanks! |
No description provided.