Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Moldavian Holidays #95

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Add Moldavian Holidays #95

merged 11 commits into from
Jan 31, 2024

Conversation

vkosachev
Copy link
Contributor

@vkosachev vkosachev commented Jan 18, 2024

These are Moldavian Holidays, based on the official dates set by the government
Reference

Since there was some misunderstanding , the Eastern Orthodox Easter is calculated using
Meeus' Julian Algorithm
php_realisation

@Nielsvanpach
Copy link
Member

Nielsvanpach commented Jan 20, 2024

There already is a orthodoxEaster() function in Country.php
Do you consider that to be a good calculation? If not, why exactly should your calculation be used ad could you provide some tests to verify?

@vkosachev
Copy link
Contributor Author

There already is a orthodoxEaster() function in Country.php Do you consider that to be a good calculation? If not, why exactly should your calculation be used ad could you provide some tests to verify?

@Nielsvanpach, you're correct. The feature wasn't present when I last updated. It appears to have been included in the a69a226e commit. The base method now performs calculations in a more brief and concise manner. Thanks for pointing that out.

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, thanks!
I'll leave it open until I see some approvals by others on the generated dates.

@Nielsvanpach
Copy link
Member

@vkosachev
Copy link
Contributor Author

In case you need multi language support: https://github.com/spatie/holidays?tab=readme-ov-file#getting-holidays-in-a-specific-language

Thanks! @Nielsvanpach what is the intention around this ? Is this to support official only languages (defined by law) or just to add support for local minorities?

@Nielsvanpach
Copy link
Member

Nielsvanpach commented Jan 24, 2024

Let's keep it with official languages.

@Nielsvanpach Nielsvanpach merged commit 8d7932e into spatie:main Jan 31, 2024
8 checks passed
@Nielsvanpach
Copy link
Member

Thanks! Feel free to still send a PR with translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants