-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Moldavian Holidays #95
Conversation
# Conflicts: # src/Countries/Moldova.php
There already is a |
@Nielsvanpach, you're correct. The feature wasn't present when I last updated. It appears to have been included in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, thanks!
I'll leave it open until I see some approvals by others on the generated dates.
tests/.pest/snapshots/Countries/MalawiTest/it_can_calculate_ugandan_holidays.snap
Outdated
Show resolved
Hide resolved
In case you need multi language support: |
Thanks! @Nielsvanpach what is the intention around this ? Is this to support official only languages (defined by law) or just to add support for local minorities? |
Let's keep it with official languages. |
Thanks! Feel free to still send a PR with translations. |
These are Moldavian Holidays, based on the official dates set by the government
Reference
Since there was some misunderstanding , the Eastern Orthodox Easter is calculated using
Meeus' Julian Algorithm
php_realisation