Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute EventSerializer is not used for serialize #414

Closed
philipp-kern opened this issue Jun 6, 2023 · 1 comment
Closed

Attribute EventSerializer is not used for serialize #414

philipp-kern opened this issue Jun 6, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@philipp-kern
Copy link

Hello!

Using the PHP attribute \Spatie\EventSourcing\Attributes\EventSerializer it is possible to set a specific serializer for an event.
This works well for deserializing the event, but not on serialize.

Because \Spatie\EventSourcing\EventSerializers\EventSerializer defines serialize in its interface I would consider this a bug.

Please also use the specified serializer on serialize of the events.

@sebastiandedeyne sebastiandedeyne added the good first issue Good for newcomers label Jul 26, 2023
@spatie-bot
Copy link

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants