Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated compose.json to handle with previous version #221

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

deniscsz
Copy link
Contributor

Change to fix #220

@freekmurze
Copy link
Member

Could you also make sure that the tests run on Laravel 8?

@deniscsz
Copy link
Contributor Author

deniscsz commented Jan 22, 2022

Could you also make sure that the tests run on Laravel 8?

@freekmurze I enabled the Github Actions in my repo and ran the tests. The results:
https://github.com/deniscsz/laravel-fractal/actions/runs/1732917159

Do you think that is necessary a specific test for laravel 8?

@freekmurze
Copy link
Member

freekmurze commented Jan 23, 2022

It seems like the test are currently only running using Laravel 8.

@dleicam
Copy link

dleicam commented Mar 16, 2022

Any news on this topic?

@stephanebelazouz
Copy link

+1

@freekmurze freekmurze merged commit 760e8d9 into spatie:main Mar 31, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency error with Laravel 8
4 participants