Correction to docs re: readonly vs isReadonly #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3.0.0 renamed readonly() to isReadonly() due to it being a reserved keyword in PHP 8.1. This updates the docs to reflect the renaming.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was in the process of switching a project from laravelcollective/html to this one, and happened to notice that the readonly() method wasn't working as documented. Digging in, I see the history, that it was renamed in version 3.0.0. This PR simply updates the documentation to reflect that change. In the process of updating the relevant file, I noticed a couple other methods out of order (where they are otherwise alphabetical) so I took the liberty of sneaking in a second commit to reorder those.