Add context to ApplicationLog #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logging, there can sometimes be additional context in the the log that would be useful to display in the This doesn't implement anything other than adding an additional argument to the constructor; the formatting will need to be implemented in the server. Additionally, the watcher in the Laravel package (and I presume the rest of the framework-specific packages) will need to be updated to pass in the context from the message object: laravel/ray Spatie\LaravelRay\Watchers/ApplicationLogWatcher:24 `$payload = new ApplicationLogPayload($message->message, $message->context);` This PR is relatively useless as the real work is done on the server-side, just putting it out there as the first step to implementing spatie#257.
|
I'm already going to merge this in, we'll update the main app at some later point in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging, there can sometimes be additional context in the the log that would be useful to display in Ray.
This doesn't implement anything other than adding an additional argument to the constructor; the formatting will need to be implemented in the server. Additionally, the watcher in the Laravel package (and I presume the rest of the framework-specific packages) will need to be updated to pass in the context from the message object:
laravel/ray Spatie\LaravelRay\Watchers/ApplicationLogWatcher:24
$payload = new ApplicationLogPayload($message->message, $message->context);This PR is relatively useless as the real work is done on the server-side, just putting it out there as the first step to implementing #257.