Fixes "case-sensitive" URI matching for Disallow rules in robots.txt #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Issue spatie#45 (Robots.txt "Disallow" URI matching should be case-sensitive) I removed the use of `strtolower` in `parseDisallow` to preserve the URI's case sensitivity. The issue was opened based on RFC standard by google which indicates: "The value of the disallow rule is case-sensitive." (Source: https://developers.google.com/search/docs/crawling-indexing/robots/robots_txt?hl=en#disallow) --- I ran PHP-Unit and all tests passed since none were specifically testing case-sensitivity. I added test the_disallows_uri_check_is_case_sensitive to cover this issue.
riasvdv
requested changes
Sep 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Issue #45 (Robots.txt "Disallow" URI matching should be case-sensitive) I removed the use of
strtolowerinparseDisallowto preserve the URI's case sensitivity.The issue was opened based on RFC standard by google which indicates:
The value of the disallow rule is case-sensitive.(Source: https://developers.google.com/search/docs/crawling-indexing/robots/robots_txt?hl=en#disallow)I ran PHP-Unit and all tests passed since none were specifically testing case-sensitivity. I added test
the_disallows_uri_check_is_case_sensitiveto cover this issue.