Fixed an error regarding the pow() function of the DaCe runtime.
#1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there was an inplementation for `T pow(T, T)`, where `T` is a template and two for the case where `T` is a signed or unsigned integer. This is a problem if we consider the call `pow(double, long long)` because the call is ambigious and results in a compiler error. As a solution I added the function `T pow(T, E)`, where both `T` and `E` are templates. I also think that the implementation of the int case could be improved because currently it is a simple for loop.
BenWeber42
reviewed
Jun 3, 2024
dace/runtime/include/dace/math.h
Outdated
| template<typename T, typename E> | ||
| DACE_CONSTEXPR DACE_HDFI T pow(const T& a, const E& b) | ||
| { | ||
| return (T)std::pow(a, (T)b); |
There was a problem hiding this comment.
Is the cast really necessary? Since C++11, there is an overload for when the two arguments have different types (overload A): https://en.cppreference.com/w/cpp/numeric/math/pow
Shouldn't we just forward directly to that overload and let the standard library pick the implementation?
There was a problem hiding this comment.
Good idea.
|
I'm closing this one, since it's superseded by #1583 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there was an inplementation for
T pow(T, T), whereTis a template and two for the case whereTis a signed or unsigned integer. This is a problem if we consider the callpow(double, long long)because the call is ambigious and results in a compiler error. As a solution I added the functionT pow(T, E), where bothTandEare templates.