Made dace::math::pow forward to std::pow more generic
#1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there was an inplementation for `T pow(T, T)`, where `T` is a template and two for the case where `T` is a signed or unsigned integer. This is a problem if we consider the call `pow(double, long long)` because the call is ambigious and results in a compiler error. As a solution I added the function `T pow(T, E)`, where both `T` and `E` are templates. I also think that the implementation of the int case could be improved because currently it is a simple for loop.
|
Thanks for the work! Looks good to me! |
|
I want to separate the Xilinx Vitis HLS compiler flag change into its own PR: #1585 |
|
LGTM |
tbennun
requested changes
Jun 8, 2024
This reverts commit 4551fe1. The change was separated into its own PR which has been merged meanwhile.
tbennun
approved these changes
Jun 12, 2024
alexnick83
pushed a commit
that referenced
this pull request
Jul 13, 2024
This overload solution will forward the argument types separately and use the same return type. --------- Co-authored-by: Berke Ates <berke@ates.ch> Co-authored-by: Berke Ates <beates@student.ethz.ch> Co-authored-by: Philipp Schaad <schaad.phil@gmail.com> Co-authored-by: Philip Mueller <philip.mueller@cscs.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overload solution will forward the argument types separately and use the same return type.