Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses issue 2445 - CC-BY-3.0 template diverges from Creative Commons published text #2451

Merged
merged 5 commits into from
May 10, 2024

Conversation

pmonks
Copy link
Contributor

@pmonks pmonks commented Apr 13, 2024

This PR addresses issue #2445 - "CC-BY-3.0 template diverges from Creative Commons published text".

HOWEVER

In updating the CC-BY-3.0.txt unit test to match the canonical version published by Creative Commons, issue #2431 was also triggered. As a result, this PR also merges in the fixes for that issue, making PR #2441 redundant.

As a reminder, issues #2431 and #2445 are unrelated, but just happen to intersect because they both involve changes in different parts of the CC-BY-3.0.txt unit test file.

Test results:

$ ./test-one-license CC-BY-3.0
WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
License Creative Commons Attribution 3.0 Unported passed
$ ./test-one-license CC-BY-NC-3.0
WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
License Creative Commons Attribution Non Commercial 3.0 Unported passed
$ ./test-one-license CC-BY-NC-ND-3.0
WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
License Creative Commons Attribution Non Commercial No Derivatives 3.0 Unported passed
$ ./test-one-license CC-BY-NC-SA-3.0
WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
License Creative Commons Attribution Non Commercial Share Alike 3.0 Unported passed
$ ./test-one-license CC-BY-ND-3.0
WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
License Creative Commons Attribution No Derivatives 3.0 Unported passed
$ ./test-one-license CC-BY-SA-3.0
WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
License Creative Commons Attribution Share Alike 3.0 Unported passed

@jlovejoy
Copy link
Member

Thanks @pmonks ! I'll review this more closely this week or weekend (on holiday / at conference the next couple days)

jlovejoy added a commit to pmonks/license-list-XML that referenced this pull request Apr 17, 2024
has other issues with this license addressed in spdx#2451
@jlovejoy jlovejoy added this to the 3.24 milestone Apr 23, 2024
@xsuchy
Copy link
Collaborator

xsuchy commented Apr 23, 2024

I want to thank you for merging these two PRs and two issues. My only problem previously was that they broke the tests, and after merging, they would break the test for all other pull requests, too.

+1 from me now.
I will leave it for @jlovejoy or somebody else to review the texts, as that is not my area of expertise.

@jlovejoy jlovejoy added the minor updates to file URL update, notes update, etc. label May 10, 2024
@jlovejoy
Copy link
Member

added comments on history to issue, but good to merge this. No change in the license text, just how it is grouped in those two bullet sections.

@jlovejoy jlovejoy merged commit 221fe23 into spdx:main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor updates to file URL update, notes update, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants