-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure licensing profile #399
Conversation
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
I propose Then this can be used for License texts as well as for Addition texts. Otherwise, we would need a |
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
bd2a7a9
to
e0d88fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a request for a discussion on my comments.
@swinslow Some rather significant restructuring as a result of the last SPDX tech call. You can see the discussion in the minutes in the etherpad (probably not moved over to minutes yet). If you'd like to discuss real-time, just ping me and I can give you more context. |
Thanks @armintaenzertng for creating this - overall structure looks good based on our discussion. A couple of review comments to consider / discuss. |
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
…singText Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
A snapshot at a0dbc34: |
@armintaenzertng - Pinging you on this one - can you go back through the review comments and update what you agree with and (re)comment on any outstanding? I just bumped into this in my java code generator and would like to merge. |
…censing also add the corresponding ProfileIdentifierTypes Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @armintaenzertng
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
Found and fixed another little bug. |
I have a few concerns about the way this is currently addressed. I'm not going to stand in the way of merging it as a next draft, but from an initial read, these are the points that I think should be addressed prior to the actual 3.0 release:
|
Per discussion with @swinslow - I'll go ahead and merge this PR and we can discuss the outstanding issues raised in the comment above after merging. |
This PR summarizes the discussion we had on the tech team call yesterday (June 27).
This moves all classes used for more in-depth modeling of licenses into the
ExpandedLicensing
profile, keeping onlyAnyLicenseInfo
,LicenseExpression
as well as a newSimpleCustomLicense
class in theLicensingProfile
.The new structure is open to discussion. I believe some descriptions have to be rewritten.