Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig and .gitattributes to enforce newline and whitespace consistency #739

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Apr 28, 2024

Using configurations from
https://github.com/spdx/spdx-spec/blob/development/v3.0.1/.editorconfig

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Using configurations from
https://github.com/spdx/spdx-spec/blob/development/v3.0.1/.gitattributes

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@zvr
Copy link
Member

zvr commented Apr 30, 2024

Why shouldn't people in Windows have their native line endings?

Sorry, I may be misunderstanding something...

@bact
Copy link
Collaborator Author

bact commented Apr 30, 2024

We can make it auto (crlf for Windows, lf for the rest), just try keeping both spdx-spec and spdx-3-model repos using the same convention.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good idea. Thank you!

@kestewart kestewart added this to the 3.0.1 milestone Apr 30, 2024
@goneall goneall merged commit d1a673a into spdx:main Apr 30, 2024
1 check passed
@bact bact deleted the add-editorconfig branch April 30, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants