Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URL clickable. #751

Closed
wants to merge 2 commits into from
Closed

Conversation

vargenau
Copy link
Contributor

No description provided.

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
@zvr
Copy link
Member

zvr commented Apr 29, 2024

In general we need to have

 see https://spdx.org

and not

 see [SPDX](https://spdx.org)

because I think it was a restriction of the ISO standard formatting (IIRC).

But maybe things have evolved; I'll ask around.

@bact
Copy link
Collaborator

bact commented Apr 30, 2024

Nice catch. Another different behavior between MkDocs and GitHub.

GitHub can automatically render this to a clickable link:

https://www.iana.org/

For the same result, MkDocs needs this:

<https://www.iana.org/>

See an example in https://spdx.github.io/spdx-spec/v3.0/model/Core/Datatypes/MediaType/

@kestewart kestewart added this to the 3.0.1 milestone Apr 30, 2024
@vargenau
Copy link
Contributor Author

@zvr @kestewart @bact

So I understand I should replace things like:

[https://spdx.org/licenses/exceptions-index.html](https://spdx.org/licenses/exceptions-index.html)

by

<https://spdx.org/licenses/exceptions-index.html>

What should I do with things like:

[RFC 2046](https://www.ietf.org/rfc/rfc2046.txt) 

Should I remove the link?

We have such kind of links in e.g.
https://spdx.github.io/spdx-spec/v3.0/serializations/

(file docs/serializations.md in https://github.com/spdx/spdx-spec)

@zvr
Copy link
Member

zvr commented May 15, 2024

I'd say we pause this one till we know (and test) the exact production process, so that we know what the requirements will be. It makes no sense to make changes now and have to make other changes later.

@bact
Copy link
Collaborator

bact commented May 15, 2024

Agree with @zvr on the pause, the knowledge of production process, and the test.

With that, we should make the knowledge and the test available and accessible more to the spec contributors. (for example, how to set up a local test)

More documentation on how spdx-3-model, spdx-spec, spec-parser, and mkdocs are working together to generate the final spec website are welcome. spdx/spdx-spec#946 is part of the attempt.

@bact
Copy link
Collaborator

bact commented May 15, 2024

Btw, it is totally understandable that we were not given the priority to such the documentation before this, since we were all focused on the release of 3.0. Now we have less pressure on that.

@bact
Copy link
Collaborator

bact commented May 15, 2024

So I understand I should replace things like:

[https://spdx.org/licenses/exceptions-index.html](https://spdx.org/licenses/exceptions-index.html)

by

<https://spdx.org/licenses/exceptions-index.html>

@vargenau From the machine point of view, both are valid Markdown and will get rendered perfectly (and identically) with mkdocs.

From the human point of view, the latter is more friendly for the human editor, less cluttered. It is less error-prone as well, because you don't have to worry about misspelling another URL.

What should I do with things like:

[RFC 2046](https://www.ietf.org/rfc/rfc2046.txt) 

If it is the ISO requirement to have the URL in clear (to make the URL visible when printed on paper), then we should expand it.

It can be something like:

RFC 2046 <https://www.ietf.org/rfc/rfc2046.txt>

or in a style according to our style guide (which I'm not sure if we have one).

@zvr
Copy link
Member

zvr commented Jul 26, 2024

So, the final outcome is that we can (and must) have links not showing, like:

see SPDX

which is written as:

 see [SPDX](https://spdx.org/)

and the production process will translate it to footnotes in the ISO standard.

model/Core/Datatypes/MediaType.md Outdated Show resolved Hide resolved
Co-authored-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Signed-off-by: Kate Stewart <13152682+kestewart@users.noreply.github.com>
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable to me. Thanks for adding these.

@bact
Copy link
Collaborator

bact commented Aug 6, 2024

All links are already got covered.
As time goes by, a change set in this PR eventually got reduced to one,
and that link is also got covered, see: https://spdx.github.io/spdx-spec/v3.0.1-draft/model/Core/Datatypes/MediaType/

We can close this PR.

@bact
Copy link
Collaborator

bact commented Aug 6, 2024

Thank you @vargenau for the PR, as we learn along the process about subtle differences between Markdown renderers.

@kestewart
Copy link
Contributor

Closing PR, as links have been handled by other PRs.

@kestewart kestewart closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants