Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 6 lib: extra "PackageSupplier" line does not get parsed correctly #63

Closed
acurry opened this issue May 3, 2023 · 1 comment · Fixed by #69
Closed

Example 6 lib: extra "PackageSupplier" line does not get parsed correctly #63

acurry opened this issue May 3, 2023 · 1 comment · Fixed by #69

Comments

@acurry
Copy link

acurry commented May 3, 2023

File: https://github.com/spdx/spdx-examples/blob/master/example6/spdx2.2/example6-lib.spdx#L16

Error when trying to parse:
Only one PackageSupplier allowed, extra at line: 16

SPDX 2.3 spec for the PackageSupplier field specifies "Single line of text with one of the following: ..."

Is there any way to configure the parser to correctly parse a .spdx document with multiple PackageSupplier lines?

@goneall
Copy link
Member

goneall commented Jul 16, 2023

Is there any way to configure the parser to correctly parse a .spdx document with multiple PackageSupplier lines?

Not currently - the spec states a maximum of one supplier. The reason for restricting to a single supplier is to avoid any ambiguous suppliers.

In SPDX 3.0 we are adding a new property that can hold "additional suppliers" but there will still be only one "primary supplier". So, I think SPDX 3.0 will solve this scenario.

I'll create a pull request to remove the extra PackageSupplier so that the examples parse correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants