Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the issue of striping attributes when beautify #458

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fixing the issue of striping attributes when beautify #458

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7b3b34
#202 Fixing Unit test failure - test_post_submit
BanulaKumarage Mar 11, 2023
9b1f727
Merge branch 'spdx:main' into main
BanulaKumarage Mar 12, 2023
78ec797
Merge branch 'main' of https://github.com/BanulaKumarage/spdx-online-…
BanulaKumarage Mar 29, 2023
ac22c1d
Revert "Merge branch 'main' of https://github.com/BanulaKumarage/spdx…
BanulaKumarage Apr 1, 2023
4aed20b
Revert "Revert "Merge branch 'main' of https://github.com/BanulaKumar…
BanulaKumarage Apr 1, 2023
c001b94
Fixing issue of striping attributes when beautify
BanulaKumarage Apr 1, 2023
231b5c3
Removed 'standardLicenseHeader' when submitting exception
BanulaKumarage Apr 2, 2023
3f06c8e
Removing global variable
BanulaKumarage Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/app/formatxml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@
'name',
'listVersionAdded',
],
'exception': [
'licenseId',
'name',
'listVersionAdded',
],
'alt': [
'name',
'match',
Expand Down Expand Up @@ -143,7 +148,9 @@ def pretty(node, level):
text = text.replace('&', '&amp;').replace('>', '&gt;').replace('<', '&lt;')
ser += text
for child in node:
ser += pretty(child, child_level)
res = pretty(child, child_level)
if not('exception' in ser and 'standardLicenseHeader' in res):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E275: missing whitespace after keyword

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonatype-lift ignore

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.

ser += res
ser += after
if tail:
ser += tail
Expand Down