Created the license v exception #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtgdk have made all the changes and fixed the conflicts, ;let me know if anything else needs to be done in this |
|
@BassCoder2808 Can you please close #492, let's not keep duplicates open if conflicts are resolved in new one ?? |
rtgdk
reviewed
Aug 24, 2023
| request.POST["xmlText"], | ||
| license_obj.text, | ||
| license_obj.isException, | ||
| is_ns, |
There was a problem hiding this comment.
Let's continue to pass arguments by name so that order doesn't get messed up when adding more args. It's always better and clearer to pass args by name.
There was a problem hiding this comment.
Let's pick all these nits later. @BassCoder2808 , merging it
rtgdk
reviewed
Aug 24, 2023
| @@ -108,6 +109,11 @@ def submitNewLicense(request): | |||
| licenseName = form.cleaned_data['fullname'] | |||
| licenseIdentifier = form.cleaned_data['shortIdentifier'] | |||
| licenseOsi = form.cleaned_data['osiApproved'] | |||
| isException = form.cleaned_data['isException'] | |||
| if isException == "False": | |||
There was a problem hiding this comment.
What if the value given is false? Use it like
isException.lower() == "true" then true else false instead
|
@BassCoder2808 Please resolve the conflict |
|
Resolved |
rtgdk
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
models.pyformatXML.pyto solve the issueform.pyto accommodate theisExceptionfield