Snippets support in Annex H, but with more structure #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2022
zvr
reviewed
Jun 15, 2022
zvr
approved these changes
Jun 16, 2022
|
The text looks good to me, but @silverhook you missed the DCO in all 4 commits. |
|
Hmm, will try to rebase and rectify this. |
Signed-off-by: Matija Šuklje <matija@suklje.name>
Signed-off-by: Matija Šuklje <matija@suklje.name>
- fixed an occurance of a wrong closing tag - fixed section case - expanded file info to include snippet info - introduced snippet nesting, incl. example Signed-off-by: Matija Šuklje <matija@suklje.name>
A more structured way to include snippets in Annex H. Signed-off-by: Matija Šuklje <matija@suklje.name>
Thanks to Alexios Zavras for the suggestion (and many others when adding snippet support to Annex H) Signed-off-by: Matija Šuklje <matija@suklje.name>
silverhook
force-pushed
the
snippets-reorder
branch
from
e33392f
to
2a85e61
Compare
goneall
approved these changes
Jun 16, 2022
|
@kestewart We should be able to get this merged in before the release candidate. If you're comfortable with the PR, please go ahead and merge. |
kestewart
approved these changes
Jun 22, 2022
jirutka
added a commit
to jirutka/zsh-history-substring-search
that referenced
this pull request
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difference to #718 is in structure: