Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-36] integrate tools-python #52

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[issue-36] integrate tools-python #52

merged 1 commit into from
Mar 8, 2023

Conversation

meretp
Copy link
Collaborator

@meretp meretp commented Feb 13, 2023

fixes #36

Task 7 fails and is therefore not included in the workflow, I opened an issue for that: #50.

Signed-off-by: Meret Behrens meret.behrens@tngtech.com

@meretp meretp marked this pull request as draft February 13, 2023 15:10
@meretp
Copy link
Collaborator Author

meretp commented Feb 13, 2023

This PR is based on the current state of the refactored branch, so I will leave this as a draft until tools-python were changed and the refactored-branch is the new main.

@meretp meretp mentioned this pull request Feb 28, 2023
Closed
@meretp meretp force-pushed the issue-36-integrate-spdx-python-tools branch 6 times, most recently from 93f6e85 to 65e4070 Compare March 6, 2023 12:13
@meretp
Copy link
Collaborator Author

meretp commented Mar 6, 2023

As soon as #53 is merged this PR can also be reviewed. #53 adds the missing artifacts so that the workflow should no longer fail once ihe PR is merged.

@meretp meretp force-pushed the issue-36-integrate-spdx-python-tools branch from 65e4070 to 44d685d Compare March 7, 2023 10:46
@meretp meretp marked this pull request as ready for review March 7, 2023 10:48
armintaenzertng
armintaenzertng reviewed Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only have a few minor remarks.

.github/workflows/tools-python.yaml Outdated Show resolved Hide resolved
spdx-tools-python-solver/testcase_generationBaselineSbom.py Outdated Show resolved Hide resolved
spdx-tools-python-solver/testcase_generationBaselineSbom.py Outdated Show resolved Hide resolved
.github/workflows/tools-python.yaml Show resolved Hide resolved
.github/workflows/tools-python.yaml Outdated Show resolved Hide resolved
@meretp meretp force-pushed the issue-36-integrate-spdx-python-tools branch 2 times, most recently from 4b98ebe to f63f2dc Compare March 8, 2023 07:12
armintaenzertng
armintaenzertng approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes :)

@meretp
[issue-36] integrate tools-python
fa8eedf 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp meretp force-pushed the issue-36-integrate-spdx-python-tools branch from f63f2dc to fa8eedf Compare March 8, 2023 09:45
@meretp meretp merged commit b505e4b into spdx:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armintaenzertng armintaenzertng armintaenzertng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate SPDX Python tools
2 participants
@meretp @armintaenzertng