Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails #30

Closed
avirlrma opened this issue Feb 26, 2018 · 4 comments
Closed

Build fails #30

avirlrma opened this issue Feb 26, 2018 · 4 comments

Comments

@avirlrma
Copy link
Contributor

The build fails for this project. The build fails for Python 3.4 and 3.5.I am working on to correct this.Any feedback would be appreciated.
@pombredanne
Copy link
Member

Good catch. I would not care supporting Python 3.4 and 3.5 ... but only 3.6 and up in earnest.

avirlrma added a commit to avirlrma/tools-python that referenced this issue Feb 27, 2018
@avirlrma
add CONTRIBUTING.md
59aab8f 
* add Contributing section to README.
* solves spdx#30
Signed-off-by: Aviral Verma <aviral1701@gmail.com>
@avirlrma
Copy link
Contributor Author

@pombredanne So we should remove 3.4,3.5 from CI configuration files,right?
Also, as you might have noticed that the errors occur because of new "byte" type in Python3.I am working on the same,while trying to avoid version-conditional code. Please give your input as well.

@yugeshk
Copy link

yugeshk commented Mar 1, 2018

Hi. are you looking to add python 3.6 to the builds as well? I was looking at all the build logs - possibly I could complete that patch.

@sschuberth
Copy link
Member

I believe this duplicates #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sschuberth @pombredanne @avirlrma @yugeshk