Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize/ deserialize annotations #280

Merged
merged 2 commits into from
Nov 14, 2022
Merged

serialize/ deserialize annotations #280

merged 2 commits into from
Nov 14, 2022

Conversation

meretp
Copy link
Collaborator

@meretp meretp commented Nov 11, 2022

fixes #275

With this PR annotations are attached to the spdx element according to the annotations.spdx_id field. Annotations that refer to external SPDX Elements aren't written as this is currently not allowed in the json-spec.

nicoweidner
nicoweidner previously approved these changes Nov 11, 2022
Copy link
Collaborator

@nicoweidner nicoweidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like your solution!

spdx/writers/jsonyamlxml.py Outdated Show resolved Hide resolved
…ppets and add associated spdx id

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
…dx elements

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp meretp merged commit 8dd1fd3 into spdx:main Nov 14, 2022
@meretp meretp deleted the issue_275 branch November 14, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jsonyamlxml] parse annotations that are nested within packages/snippets/files
2 participants