Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tv-parser] fix parsing of annotation type #282

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

meretp
Copy link
Collaborator

@meretp meretp commented Nov 11, 2022

Fixes the error described in #196 for parsing the annotation type in tv-files.
I also added two tests to verify that annotations are parsed correctly.

nicoweidner
nicoweidner previously approved these changes Nov 11, 2022
Copy link
Collaborator

@nicoweidner nicoweidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some very minor comments, thanks for the fix!

spdx/parsers/tagvalue.py Show resolved Hide resolved
tests/test_tag_value_parser.py Outdated Show resolved Hide resolved
tests/test_tag_value_parser.py Show resolved Hide resolved
nicoweidner
nicoweidner previously approved these changes Nov 14, 2022
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp meretp merged commit 8c86b22 into spdx:main Nov 14, 2022
@meretp meretp deleted the issue-196 branch November 14, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants