-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue-181] add files at document-level #288
Conversation
595f2ef
to
c38fea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the big contribution! I left a bunch of suggestions, but it looks very good overall
0f4d147
to
f002bd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few more things, but I think we are pretty close now!
cdd095c
to
6a6fba6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some nits left, thanks for addressing everything!
leads to failing test concerning rdf-files Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
…iter/parser leads to failing tests for rdf and tv files Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
6a6fba6
to
dfeee30
Compare
This PR is still in progress but attempts to fix #181.
also fixes #297
Signed-off-by: Meret Behrens meret.behrens@tngtech.com