[issue-299] allow single line of text in free form text #300
Conversation
meretp
changed the title
|
Todo: adapt docstrings |
meretp
changed the title
meretp
changed the title
Done, ready for review |
| @@ -16,7 +16,7 @@ PackageVerificationCode: SOME code | |||
| PackageLicenseDeclared: NOASSERTION | |||
| PackageLicenseConcluded: NOASSERTION | |||
| PackageLicenseInfoFromFiles: LGPL-2.1-or-later | |||
| PackageCopyrightText: <text>Some copyrught</text> | |||
| PackageCopyrightText: Some copyrught | |||
There was a problem hiding this comment.
If you touch this line, you might as well fix the typo 😛
There was a problem hiding this comment.
There are actually 14 occurences of copyrught in the project :D
There was a problem hiding this comment.
If I remember correctly, it was once fixed in a PR, but probably reverted during some merge conflicts or whatever, but I will change this now, it really bothers my inner Monk (not sure if this is the correct translation)..
tests/data/doc_write/tv-simple.tv
Outdated
| @@ -16,7 +16,7 @@ PackageVerificationCode: SOME code | |||
| PackageLicenseDeclared: NOASSERTION | |||
| PackageLicenseConcluded: NOASSERTION | |||
| PackageLicenseInfoFromFiles: LGPL-2.1-only | |||
| PackageCopyrightText: <text>Some copyrught</text> | |||
| PackageCopyrightText: Some copyrught | |||
| def p_text_or_line_value_1(self, p): | ||
| """text_or_line : TEXT""" | ||
| p[0] = p[1] | ||
|
|
||
| def p_text_or_line_value_2(self, p): | ||
| """text_or_line : LINE""" | ||
| p[0] = p[1] |
There was a problem hiding this comment.
This looks absurd, but seems to be doing the right thing!
There was a problem hiding this comment.
Yes, in the tag-value lexer, a TEXT is a string (possibly multi-line) enclosed in <text>, while LINE is a single line without the tags. Some properties don't allow TEXT, so there has to be a distinction.
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
…d validate_is_free_form_text_or_str Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
single_line_of_test_in_free_form_text
branch
from
0b3abc0
to
7513c39
Compare
fixes #299
Signed-off-by: Meret Behrens meret.behrens@tngtech.com