[issue-261] delete duplicated files #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoweidner
requested changes
Nov 25, 2022
README.md
Outdated
| @@ -51,7 +51,7 @@ This is the result of an initial GSoC contribution by @[ah450](https://github.co | |||
|
|
|||
| 1. **PARSER** (for parsing any format): | |||
| * Use `pyspdxtools_parser --file <filename>` where `<filename>` is the location of the file. | |||
| Try running: `pyspdxtools_parser --file data/SPDXRdfExample.rdf`. | |||
| Try running: `pyspdxtools_parser --file tests/data/formats/SPDXRdfExample.rdf`. | |||
There was a problem hiding this comment.
The example files in test/data/formats/ are not included in built distributions, only in source distributions (the same is true for the example files in data/, for that matter). We should rephrase these comments to something like "If you are using a source distribution, try running..."
nicoweidner
approved these changes
Nov 25, 2022
… in README Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
delete_duplicated_example_files
branch
from
99c4cc1
to
c210c56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #261
Signed-off-by: Meret Behrens meret.behrens@tngtech.com