Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-376] add tests for spdx_id_validators #460

Merged
merged 1 commit into from Feb 1, 2023
Merged

[issue-376] add tests for spdx_id_validators #460

merged 1 commit into from Feb 1, 2023

Conversation

armintaenzertng
Copy link
Collaborator

also fix some strings

fixes #376

Signed-off-by: Armin Tänzer armin.taenzer@tngtech.com

@armintaenzertng
[issue-376] add tests for spdx_id_validators
723cb97 
also fix some strings

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
meretp
meretp approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think, you achive a pretty high test coverage for this piece of code, I especially like the "SPDXRef-Filet"! 🥩 😆

@armintaenzertng armintaenzertng merged commit 0c8c30d into spdx:refactor-python-tools Feb 1, 2023
@armintaenzertng armintaenzertng deleted the testSpdxIdValidators branch February 1, 2023 14:48
@armintaenzertng armintaenzertng mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meretp meretp meretp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@armintaenzertng @meretp