Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possibile to set encoding #471

Merged
merged 3 commits into from Feb 10, 2023
Merged

Conversation

chrisdecker1201
Copy link
Contributor

No description provided.

@meretp
Copy link
Collaborator

meretp commented Feb 10, 2023

Hi @chrisdecker1201, thanks for your contribution! This looks like a useful feature. Can you please add the signoff to your commits so that this can be merged? (see here

Also, I have one question out of curiosity: I would assume that you use the tools-python as a library and as you also spoke up for the feature to merge SPDX documents: How or in what context are you using the tools?

Signed-off-by: Christian Decker <christian.decker@homag.com>
Signed-off-by: Christian Decker <christian.decker@homag.com>
@chrisdecker1201
Copy link
Contributor Author

@meretp Your assumption is correct 😄. We are getting a SPDX file from a third-party application and have to add additional SPDX information to this file. Therefore our developers should checkin this additional SPDX information into the repository and we are developing a tool for combining the files in the CI/CD process.

Additionally we use this to validate the SPDX file.

Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the sign-off! I have some small remarks on the last changes.

requirements.txt Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
spdx/parsers/parse_anything.py Outdated Show resolved Hide resolved
Signed-off-by: Christian Decker <christian.decker@homag.com>
Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the remarks, this looks good to me! And also thanks for sharing your usecase!

@meretp meretp merged commit d6932e2 into spdx:main Feb 10, 2023
@chrisdecker1201 chrisdecker1201 deleted the feature/encoding branch February 15, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants