Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up examples #482

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Conversation

meretp
Copy link
Collaborator

@meretp meretp commented Feb 14, 2023

As a start to solving #360 I deleted those files which aren't valid according to the spec. Or more precise: json, yaml and xml formats weren't defined in specVersion 2.1, so it does not make sense to keep these examples in the repo. Additionally, I deleted some data in the SBOM file which were added later on, probably to test a feature development but doesn't make sense for the original file. Trying to parse the SBOM file would still cause a ValidationError but as this is a file from specVersion 2.2 and the validation is still an open issue (#463), I think we can leave the example as is in the repo.

… schema for json/yaml/xml

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meretp meretp merged commit fa0c215 into spdx:refactor-python-tools Feb 15, 2023
@meretp meretp deleted the clean-up-examples branch February 15, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants