add script to publish from tag #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhbr
force-pushed
the
add_script_to_publish_from_prerelease
branch
from
8a24096
to
6b29682
Compare
publish_from_tag.sh
Outdated
| echo " . ./venv/bin/activate" | ||
| echo " . ./venv/bin/activate.fish" | ||
| echo | ||
| echo "will try to avtivate..." |
There was a problem hiding this comment.
Suggested change
| echo "will try to avtivate..." | |
| echo "will try to activate..." |
maxhbr
force-pushed
the
add_script_to_publish_from_prerelease
branch
2 times, most recently
from
74f9a01
to
adb7496
Compare
There was a problem hiding this comment.
In #726, we add a dev directory on top-level, this script might be well placed there.
publish_from_tag.sh
Outdated
Comment on lines
26
to
31
| if ! command -v twine &> /dev/null; then | ||
| echo "twine could not be found" | ||
| echo "maybe load venv with" | ||
| echo " . ./venv/bin/activate" | ||
| echo " . ./venv/bin/activate.fish" | ||
| echo |
There was a problem hiding this comment.
maybe exit somewhere here? Else it will fail on line 49
maxhbr
force-pushed
the
add_script_to_publish_from_prerelease
branch
3 times, most recently
from
349efb3
to
40fadd3
Compare
armintaenzertng
previously approved these changes
Jul 20, 2023
Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
maxhbr
force-pushed
the
add_script_to_publish_from_prerelease
branch
from
40fadd3
to
758afa5
Compare
armintaenzertng
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably would deserve a better placement, description and/or name