Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in diffs-from-previous-editions.md #18

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Fix typos in diffs-from-previous-editions.md #18

merged 7 commits into from
Oct 1, 2024

Conversation

bact
Copy link
Contributor

@bact bact commented Sep 26, 2024 •
edited
Loading

  • definingDocument -> definingArtifact
  • hasDistributionArifact -> hasDistributionArtifact
  • SpecVersiononly -> SpecVersion only
  • ContentIdentifers -> ContentIdentifiers
  • ExtractedLicenseInfo -> extractedText (in ExtractedLicensingInfo class)
  • LicenseInfoInFiles -> LicenseInfoInFile
  • match casing in SPDX 3 Software Purpose table with casing in SoftwarePurpose entries
    • Also add application/spdx+json to SPDX 3 Content Type, in addition to text/spdx

@bact
Fix typo: hasDistributionArifact -> hasDistributionArtifact
0411bc8 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
SpecVersiononly -> SpecVersion only
924b1a3 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact changed the title Fix typo: hasDistributionArifact -> hasDistributionArtifact Fix typos in diffs-from-previous-editions.md Sep 26, 2024
@bact
ContentIdentifers -> ContentIdentifiers
02768c1 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact mentioned this pull request Sep 26, 2024
Draft
@bact
definingDocument -> definingArtifact
3b04902 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
ExtractedLicenseInfo -> extractedText (in ExtractedLicensingInfo class)
241401a 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
LicenseInfoInFiles -> LicenseInfoInFile
9dd0d04 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
bobmartin3000
bobmartin3000 approved these changes Oct 1, 2024
View reviewed changes
Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bact
Add application/spdx+json to SPDX in Content Type table
be4efc7 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
goneall
goneall approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall merged commit c4f5e51 into spdx:main Oct 1, 2024
@bact bact deleted the patch-2 branch October 1, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobmartin3000 bobmartin3000 bobmartin3000 approved these changes

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @goneall @bobmartin3000