properly handle /Lang with mainlanguage

[pr-apes]

No description provided.

[pgundlach]

Thank you for the patch. I see a few issues here (which can be easily solved)

• A layout.xml with <Options /> breaks (when no mainlanguage=".." is in the Options command)
• Not sure if it necessary to introduce another variable sp_mainlanguage
• The (default) language is written to the document even if it is unset. This is probably a good idea, but it breaks backwards compatibility. So if unset, it should be left out.

I'll have a look

[pr-apes]

I reply to your issues (after #434 (comment)).

1. I hadn't checked that. Totally my fault.
2. I thought it was clearer to have a sp_mainlanguage variable. And I'm not sure I know how to read the value from --mainlanguage for /Lang without it.
3. Sorry, but I don't understand how adding the main document language to /Lang might break backwards compatibility.

Let me elaborate my last point. /Lang is metadata (in a very similar way as /Creator is metadata for the PDF document).

If I a newer version of Publisher is used with the same layout and data sources, /Creator will be different.

Sorry, but I don't think this breaks backwards compatibilty. Only the output in that given field isn't the same.

The document main language may be not set by the user, but Publisher defaults it to British English.

To the best of my knowledge, text is hyphenated according to the patterns for this language (unless deactivated).

In my opinion, adding the main language to PDF metadata doesn't break existing functionality in an incompatible way.

But of course, this is up to you. Let me know what you think about last two points.

[pgundlach]

My third point is stupid. It will have byte changes in the documents but you are right that it will not change anything from the user perspective. So we should add it

I will take a look

[pr-apes]

Just as a comment, :match("%a+") solves the issue with language identifiers involving geographical regions.

if options.mainlanguage ~= nil and options.mainlanguage ~= "" then
    pdfcatalog[#pdfcatalog + 1] = string.format("/Lang (%s)", (language_mapping[options.mainlanguage] or options.mainlanguage):match("%a+"))
elseif sp_mainlanguage then
    pdfcatalog[#pdfcatalog + 1] = string.format("/Lang (%s)", (language_mapping[sp_mainlanguage] or sp_mainlanguage):match("%a+"))
end

[pr-apes]

Also fixed layout with options but not main language.

The culprit was

if options.mainlanguage ~= "" then

and this fixes it:

if options.mainlanguage ~= nil and options.mainlanguage ~= "" then

I will try to correct my own patches (not sure whether GH will allow me that).

[pr-apes]

I have to close this pull request to provide a new one.

[pgundlach]

I believe you think too complicated.

IIRC you just need to put the /Lang field into the catalog with the field 'locale' of the lang object which you get with get_language(defaultlanguage) I think for a start it would be enough to have the first locale part.

No need to have an extra sp_mainlanguage or any other code in the commands.lua file
(I might be wrong though)